> On March 20, 2013, 2:18 p.m., Aaron J. Seigo wrote: > > plasmate/savesystem/dvcsjob.h, line 82 > > <http://git.reviewboard.kde.org/r/109500/diff/1/?file=119940#file119940line82> > > > > is this used anywhere? > > > > also, it is tradition to put the "Unknown" defintion as the first item > > in the enumeration, set to 0.
No its not used anywhere. Its a leftover. > On March 20, 2013, 2:18 p.m., Aaron J. Seigo wrote: > > plasmate/savesystem/gitrunner.cpp, line 125 > > <http://git.reviewboard.kde.org/r/109500/diff/1/?file=119943#file119943line125> > > > > i wonder if this works if the shell is set to a different lang > > environment? or is git simply not translated? git isn't translated, its only in english :) my terminal is in Greek but the git status is in english http://paste.opensuse.org/37520051 - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109500/#review29557 ----------------------------------------------------------- On March 15, 2013, 4:52 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109500/ > ----------------------------------------------------------- > > (Updated March 15, 2013, 4:52 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hello, > > this patch is the refactor of the savesystem. > > Also in this refactor the above bugs are being fixed. > > Q: Why do we need a refactor? > A: * Before this patch in order to take the git log we did > some parsing, which wasn't nice. With this patch we use git log > --pretty-format. > * There are some other changes like coding style stuff and striping \n from > strings. > > > This addresses bugs 316202, 316724 and 316725. > http://bugs.kde.org/show_bug.cgi?id=316202 > http://bugs.kde.org/show_bug.cgi?id=316724 > http://bugs.kde.org/show_bug.cgi?id=316725 > > > Diffs > ----- > > plasmate/savesystem/dvcsjob.h 38df371 > plasmate/savesystem/dvcsjob.cpp 288d7a6 > plasmate/savesystem/gitrunner.h 50f87ab > plasmate/savesystem/gitrunner.cpp b263be6 > plasmate/savesystem/timeline.h 73849d0 > plasmate/savesystem/timeline.cpp 231fc46 > > Diff: http://git.reviewboard.kde.org/r/109500/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
