----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108935/#review27372 -----------------------------------------------------------
Ship it! a couple of small code style issues, but otherwise this can go in. i don't think we'll need (or want) any such support in Plasma::Package; the shell can get at everything necessary. this will need to be added to the new shell as well in plasma workspaces 2 when it becomes available. i'm not a big fan of adding yet more to our porting efforts, to be honest ... but if this is useful to QA then we can make an exception. plasma/desktop/shell/supportinformation.cpp <http://git.reviewboard.kde.org/r/108935/#comment20596> foreach ( plasma/desktop/shell/supportinformation.cpp <http://git.reviewboard.kde.org/r/108935/#comment20597> foreach ( - Aaron J. Seigo On Feb. 13, 2013, 12:46 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108935/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 12:46 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Add a DBus method to plasma-desktop to provide support information for easier > bug triaging > > Method call is org.kde.plasma-desktop /App local.PlasmaApp.supportInformation > > This is based on kwin support information, and is based a comment made in the > quality ML thread. It can probably be extended in many ways but this is an > initial version that we can add to as we see fit. Ideally in Plasma2 we can > add a support information to the Plasma::Package API if it proves to be > worthwhile to get more specific information. > > In it's current state by listing plasmoids we can triage most the python > crashes by working out which plasmoid is fault. > > I would like to push this into 4.10.1 > > > Diffs > ----- > > plasma/desktop/shell/supportinformation.cpp PRE-CREATION > plasma/desktop/shell/supportinformation.h PRE-CREATION > plasma/desktop/shell/plasmaapp.cpp aafd037 > plasma/desktop/shell/plasmaapp.h 6ae0c89 > plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 > plasma/desktop/shell/CMakeLists.txt 95d7db1 > > Diff: http://git.reviewboard.kde.org/r/108935/diff/ > > > Testing > ------- > > Sample output attached. > > > File Attachments > ---------------- > > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/13/plasma_support_information.txt > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
