-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106755/
-----------------------------------------------------------
(Updated Oct. 8, 2012, 9:31 a.m.)
Review request for KDE Base Apps and Plasma.
Changes
-------
Accepted that the /dev/XXXX name is technical information and usually not
useful to the user. However, the mount point is (especially in the case of
needing to access the device from non-KDE applications); most distros are
standardised on /media/LABEL now but, even if the user knows that, the device
label is nowhere currently available in the GUI.
The updated patch shows a tool tip over the device label. It can say one of:
Not mounted
Mounted on /media/YYYY
Mounted
It could be argued that the word "mount" is technical jargon and should not be
used, but I can't think of a suitable alternative (and "mount" is the term used
elsewhere).
Agreed that the best resolution for "can't unmount" would be to show
applications or processes that are blocking the mount, but implementing that is
not trivial (as discussed in bug 96107).
Not convinced that the place to find this information is another Properties
dialogue, especially if it it necessary to open or go to another application -
in this case the user may as well open a terminal window and type 'df' or
'mount'...
Description
-------
If a removable device is mounted using the Plasma device notifier, there is no
indication of what the Unix name of the device is or where it is mounted. This
information may be useful to the user for (a) accessing the mounted device from
non-KDE applications, or (b) troubleshooting mounting or unmounting problems.
The attached patch shows this information when the device is hovered over, just
above the "N actions for this device" text. Depending on whether or not the
device is mounted, there are three possibilities that can be shown here:
/dev/XXX when not mounted
/dev/XXX mounted on /media/YYYY when mounted
/dev/XXX mounted if mounted but the mount point is not
available
Please be gentle, this is my first QML patch :-)
This addresses bug 196939.
http://bugs.kde.org/show_bug.cgi?id=196939
Diffs (updated)
-----
plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml
396de2c
Diff: http://git.reviewboard.kde.org/r/106755/diff/
Testing
-------
Built kde-workspace with this change, observed operation and display of device
notifier with a selection of removable devices.
Screenshots
-----------
Device notifier with mounted device
http://git.reviewboard.kde.org/r/106755/s/756/
Thanks,
Jonathan Marten
_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel
