----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/ -----------------------------------------------------------
Review request for Plasma. Summary ------- This patch fixes some usability problems in the fifteen puzzle's config: * Don't apply the settings before the user presses OK. This was counter-intuitive and broke the cancel button. * Remove the shuffle button, it doesn't really belong in the config to begin with (I'm working on a patch to add it in the bottom right of the solved puzzle). * Only update the size of the puzzle if the user actually changed it (this prevents unnecessary resets to the solved view when the user eg. toggles the numerals). * Use configChanged() and configAccepted() properly. Also, don't update the pixmaps unless they actually need to be updated, this fixes some inefficiencies (eg. when moving pieces). Diffs ----- /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/CMakeLists.txt 1184493 /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1184493 /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h 1184493 /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1184493 /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.h 1184493 /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.cpp 1184493 /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 1184493 Diff: http://svn.reviewboard.kde.org/r/5608/diff Testing ------- Tested changing between different configurations. Screenshots ----------- New config dialog http://svn.reviewboard.kde.org/r/5608/s/534/ Thanks, Anthony
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
