ngraham added inline comments.
INLINE COMMENTS
> broulik wrote in UserDetailsPage.qml:217
> Can you add some way to make Escape close the sheet but not the entire KCM,
> when run standalone through kcmshell? Hopefully the following is sufficient,
> otherwise you'd have to mess with `FocusScope` and the like:
>
> Keys.onEscapePressed: {
> close();
> event.accepted = true;
> }
FWIW KCMs opened through KRunner are now opened in System Settings so KCMShell
is something we're going to have to deal with much less. :)
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D28154
REVISION DETAIL
https://phabricator.kde.org/D28154
To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev,
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel,
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
ahiemstra
