ngraham added a comment.
Looks fantastic!
However I've applied the dependent patches, but this doesn't compile for me:
In member function ‘virtual void SystemMonitor::init()’:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:63:78:
error: invalid use of incomplete type ‘class SensorFaceController’
63 | m_sensorFaceController = new SensorFaceController(cg,
qmlObject->engine());
|
^
In file included from
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
note: forward declaration of ‘class SensorFaceController’
33 | class SensorFaceController;
| ^~~~~~~~~~~~~~~~~~~~
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:67:31:
error: invalid use of incomplete type ‘class SensorFaceController’
67 | m_sensorFaceController->loadPreset(m_pendingStartupPreset);
| ^~
In file included from
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
note: forward declaration of ‘class SensorFaceController’
33 | class SensorFaceController;
| ^~~~~~~~~~~~~~~~~~~~
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:71:31:
error: invalid use of incomplete type ‘class SensorFaceController’
71 | m_sensorFaceController->loadPreset(preset);
| ^~
In file included from
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
note: forward declaration of ‘class SensorFaceController’
33 | class SensorFaceController;
| ^~~~~~~~~~~~~~~~~~~~
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:
In member function ‘virtual void SystemMonitor::configChanged()’:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:83:31:
error: invalid use of incomplete type ‘class SensorFaceController’
83 | m_sensorFaceController->reloadConfig();
| ^~
In file included from
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
note: forward declaration of ‘class SensorFaceController’
33 | class SensorFaceController;
| ^~~~~~~~~~~~~~~~~~~~
Also the test plan screenshot shows a string overlap issue: F8283936:
Screenshot_20200504_085406.png <https://phabricator.kde.org/F8283936>
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28487
To: mart, #plasma
Cc: ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage,
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
