ngraham added a comment.

  5.19 hasn't branched yet, so code landed in master will still make it there.
  
  With this patch, I still see Media Player itself with a blank icon after 
opening Gwenview. Is that expected?
  
  F8282515: Screenshot_20200503_215149.png 
<https://phabricator.kde.org/F8282515>

INLINE COMMENTS

> ItemLoader.qml:33
>          }
> +        console.warn("ItemLoader: Illegal State! Cannot determine source!")
>          return ""

"Illegal" is one of those scary words we try not to use, even in console spew. 
Consider changing this to "Invalid."

F8282506: Screenshot_20200503_214934.png <https://phabricator.kde.org/F8282506>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29344

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, 
davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

Reply via email to