mart added inline comments.
INLINE COMMENTS
> Sensor.cpp:207
> +
> + if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()")
> != -1) {
> + connect(parent(), SIGNAL(enabledChanged()), this,
> SIGNAL(enabledChanged()));
if (
> SensorDaemonInterface.cpp:87
> + auto watcher = new
> QDBusPendingCallWatcher{d->dbusInterface->sensorData({sensorId}), this};
> + connect(watcher, &QDBusPendingCallWatcher::finished, watcher,
> [=](QDBusPendingCallWatcher *self) {
> + self->deleteLater();
also here, [this] instead of [=]
> SensorsPlugin.cpp:2
> /*
> - Copyright (C) 2019 Vlad Zagorodniy <[email protected]>
> + Copyright (C) 2020 Arjen Hiemstra <[email protected]>
>
also here
> SensorsPlugin.h:2
> /*
> - Copyright (C) 2019 Vlad Zagorodniy <[email protected]>
> + Copyright (C) 2020 Arjen Hiemstra <[email protected]>
>
shouldn't remove existing copyrights?
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D28141
To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
