davidedmundson added a comment.
Technically this introduces a visual change.
Dialog draws a border and shadow by default which appears outside our red
border from the QML.
I'm pretty sure you can disable it in Dialog, but frankly this looks way
better so maybe it's a feature.
INLINE COMMENTS
> output_identifier.cpp:58
> if (!rootObj) {
> continue;
> }
Not part of your change, but we would leak view here.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D28817
To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n,
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, ahiemstra, mart
