ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> colorsstateprobe.cpp:29
> + : KCModuleStateProbe(parent, args)
> + , m_settings(new ColorsSettings(this))
> +{
I'm not sure I see the point of doing this... You don't need that member
variable anyway. You could just have in the ctor body the following:
`registerSetting(new ColorsSettings(this));`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D28462
To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
