mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pagerouter.h:12
> +
> +struct ParsedRoute {
> + QString name;
is this still needed for routes that are a composition of PageRoute objects
like /path/to/some/thing?
> pagerouter.h:66
> + */
> + Q_PROPERTY(bool cache MEMBER m_cache READ cache)
> +
since is per page this global property should go
> pagerouter.h:91
> + */
> +class PageRouter : public QQuickItem
> +{
any reason this should be a qquickitem?
this doesn't display things per se, neither should be a parent of items, but
just to remote control a given pagerow, it should be a QObject
> pagerouter.h:114
> + */
> + Q_PROPERTY(QJSValue initialRoute READ initialRoute WRITE setInitialRoute
> NOTIFY initialRouteChanged)
> +
Q_PROPERTY(QString initialRoute (provided the route name is unique, which
should be checked and some type of error thrown if not)
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D28383
To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson,
dkardarakos, ngraham, apol, mart
