broulik added inline comments.
INLINE COMMENTS
> jgrulich wrote in screencaststream.cpp:376
> Does it need to be specified if you have Urgency=Normal set in the notifyrc
> file? I believe if you don't specify it, it will use the default urgency,
> which will be taken from the notifyrc file.
"Normal" is the default and doesn't need specifying anywhere
> xdg-desktop-portal-kde.cpp:33
> QApplication a(argc, argv);
> + a.setApplicationName(QStringLiteral("xdp_kde"));
> a.setQuitOnLastWindowClosed(false);
I think this should remain as `xdg-desktop-portal-kde` - doesn't this also have
implications on i18n?
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
REVISION DETAIL
https://phabricator.kde.org/D28517
To: cblack, #plasma, #vdg, ngraham, apol, jgrulich
Cc: broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
