crossi added inline comments.
INLINE COMMENTS
> kcm.cpp:73
> +
> +void KCMUser::defaults()
> +{
Not necessary to override if you don't add your specific implementatioin.
> kcm.cpp:78
> +
> +void KCMUser::load()
> +{
same here
> user.cpp:53
> + mName = value;
> + nameChanged(value);
> +}
Add `emit` or `Q_EMIT` before signal calls
> user.cpp:66
> + mRealName = value;
> + realNameChanged(value);
> +}
Add `emit` or `Q_EMIT` before signal calls
> user.cpp:79
> + mEmail = value;
> + emailChanged(value);
> +}
Add `emit` or `Q_EMIT` before signal calls
> user.cpp:110
> + mAdministrator = value;
> + administratorChanged(value);
> +}
Add `emit` or `Q_EMIT` before signal calls
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D28154
To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham,
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
