davidre requested changes to this revision.
davidre added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> breezehelper.cpp:1782
> + auto borderSize = kdecorationGroup.readEntry("BorderSize",
> "Invalid");
> + if (borderSize != "None" && borderSize != "NoSides") {
> + return false;
This check is the problem. If "Use Theme's default border size" is checked (the
default) then no entry will be written in the config file because the defaults
are used. This is for`BorderSizeAuto` "true" and for `BorderSize` "Normal"
(Note however that because of the the BorderSizeAuto the default borders of the
deco are used and not normal sized borders)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D27669
To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin,
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart