gikari added inline comments.
INLINE COMMENTS
> CMakeLists.txt:3
> +
> +enable_language(C)
> +
Why is this needed? Aren't the CMake default languages in project (parent
CMakeLists) both `CXX` and `C`?
> reloader.c:35
> +__attribute__((visibility("default"))) void gtk_module_init(gint *argc,
> gchar ***argv[]) {
> + path = g_strconcat(g_get_home_dir(), "/.config/gtk-3.0/colors.css",
> NULL);
> + file = g_file_new_for_path(path);
This is hardcoded directory. The $XDG_CONFIG_HOME may be set to something
other, not only the default.
REPOSITORY
R99 KDE Gtk Configuration Tool
BRANCH
arcpatch-D28076
REVISION DETAIL
https://phabricator.kde.org/D28076
To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
ahiemstra, mart
