romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Nice tight implementation.
INLINE COMMENTS
> output_model.cpp:497
> + const QString text = i18nc("Width x height (aspect ratio)", "%1x%2
> (%3:%4)",
> + // Explicitly not have it add
> thousand-separators
> + QString::number(size.width()),
It's a sentence. So there should be a full stop in the end.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D27674
To: broulik, romangg, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart