meven added inline comments.
INLINE COMMENTS
> crossi wrote in componentchooseremail.cpp:154
> While you are here, can you had a check on this pointer. I don't understand
> why there is one below but not here.
I would rather do the opposite the check below is for historical reasons from
before my refactoring.
> crossi wrote in componentchooserfilemanager.cpp:117
> I would have kept this test that is more clearer than `if (currentIndex() ==
> count() - 1) {}` if you confirm it works the same.
It would test twice the same thing : only the last value in the combobox can
have an empty currendData.
I'd rather have the same combo accross the CfoPlugin.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27395
To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
