davidedmundson accepted this revision.
davidedmundson added a comment.
> In more long term we need to fix ConfigModule do you think is better to do
a setNeedsSave(false) after loading or emiting signal in all case ?
I think we need something, I've seen some similar report in the nightmode KCM
about the apply button.
I would personally say the right thing is to remove this line:
QMetaObject::invokeMethod(this, "changed", Qt::QueuedConnection,
Q_ARG(bool, false));
As I don't see what it is trying to do
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27384
To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson,
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart