zzag added inline comments.
INLINE COMMENTS
> apol wrote in breezeshadowhelper.h:157
> if this is a thing, maybe it would make sense to actually try and remove the
> KWindowShadows upon destruction?
> Something like `connect(newshadow, &QObject::destroyed, this, [this, widget]
> { _shadows.remove(widget); });`
> if this is a thing, maybe it would make sense to actually try and remove the
> KWindowShadows upon destruction?
Yes, that's a better idea.
> broulik wrote in breezeshadowhelper.h:157
> We have a connection to `destroyed` for the `widget` which isn't reached when
> a window is destroyed on `QApplication` teardown, so I think the same might
> be true for the window, I would still prefer this over a `QPointer`.
> so I think the same might be true for the window
No, it works fine.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D26966
To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
