broulik added inline comments.
INLINE COMMENTS
> settings.cpp:40
>
> +const static QString s_configFile { QStringLiteral("plasmanotifyrc") };
> +
Global statics are to be avoided in libraries
> settings.cpp:183
>
> +Settings::Settings(const KSharedConfig::Ptr &, QObject *parent)
> + : Settings(parent)
I prefer to have a name and then explicitly `Q_UNUSED` in the function body
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26834
To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
