broulik added a comment.
Other than the seemingly missing `config`, looks good
INLINE COMMENTS
> settings.cpp:173
> - if (!s_settingsInited) {
> - DoNotDisturbSettings::instance(config);
> - NotificationSettings::instance(config);
I still want to be able to specify what `config` (constructor argument) to use
for autotests
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26047
To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
