davidedmundson added a comment.
With any layout changes be sure you've tested it:
- in the system tray
- in the panel
- in a vertical panel
- on the desktop
INLINE COMMENTS
> BatteryItem.qml:96
> + RowLayout {
> + width: batteryItem.width
> +
We want to almost never specify a width inside a layout
It's the layout's job to change the item's width, which means when it re does
the layout this information gets lost.
Instead, we want to set an implicitWidth or Layout.preferredWidth
This applies throughout
> PowerManagementItem.qml:69
> + if (suppressHint.visible) {
> + mainMessage += i18n("\n") + suppressHint.text
> + }
there's no point translating "\n"
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26806
To: gvgeo, #plasma, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
