ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> componentchooserterminal.cpp:76
> +
> + const auto constraint = QStringLiteral("'TerminalEmulator' in Categories
> AND (not exist NoDisplay OR NoDisplay != true)");
> + const auto terminalEmulators =
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), constraint);
`NoDisplay == false` seems slightly more readable than `NoDisplay != true`
REPOSITORY
R119 Plasma Desktop
BRANCH
terminal-config
REVISION DETAIL
https://phabricator.kde.org/D26705
To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
