ngraham added reviewers: VDG, Plasma.
ngraham added a comment.
Doesn't build for me:
[ 67%] Building CXX object
kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/kcmspellchecking_autogen/mocs_compilation.cpp.o
/home/nate/kde/src/plasma-desktop/kcms/formats/kcm.cpp: In constructor
‘Formats::Formats(QObject*, const QVariantList&)’:
/home/nate/kde/src/plasma-desktop/kcms/formats/kcm.cpp:39:5: error:
‘qmlRegisterAnonymousType’ was not declared in this scope; did you mean
‘qmlRegisterSingletonType’?
39 | qmlRegisterAnonymousType<FormatsSettings>("kcm.kde.org", 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| qmlRegisterSingletonType
Also it would be nice if you could put a screenshot in the Test Plan section
so VDG people can do basic UI review without having to compile it.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25449
To: tcanabrava, ervin, #vdg, #plasma
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, ahiemstra
