broulik added inline comments.
INLINE COMMENTS
> vaultsmodel.cpp:103
>
> + if (vaultKeys.size() > 0) {
> + emit q->countChanged(vaultKeys.size());
You probably want to remember the old count and emit when it's different. The
model could have been full and become empty after all.
> vaultsmodel.h:45
>
> int rowCount(const QModelIndex &parent) const override;
>
If you give `parent` a default argument you can just use that in your property
rather than adding a dedicated `count` method
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D26447
To: ngraham, broulik, ivan, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
