ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> MainConfigurationWidget.cpp:59
>
> +void MainConfigurationWidget::checkDefault() {
> + defaulted(d->tabSwitching->isDefault() && d->tabPrivacy->isDefault());
Opening curly brace should be on its own line here
> MainConfigurationWidget.cpp:63
> +
> +void MainConfigurationWidget::onChanged() {
> + checkDefault();
Ditto
> PrivacyTab.cpp:140
>
> +bool PrivacyTab::isDefault() {
> + return d->radioRememberAllApplications->isChecked() &&
Ditto
> SwitchingTab.cpp:90
>
> +bool SwitchingTab::isDefault() {
> + return !d->checkRememberVirtualDesktop->isChecked();
{ should be on its own line
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26289
To: meven, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
