davidre added inline comments.
INLINE COMMENTS
> themesmodel.cpp:161
> + QStringList themes;
> + const QStringList &packs =
> QStandardPaths::locateAll(QStandardPaths::GenericDataLocation,
> QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory);
> + for(const QString &ppath : packs) {
Yeah that doesn't look right. The load method is a straight copy from the old
load method.
> themesmodel.cpp:237
> +
> + for (const auto &item : m_data) {
> + if (item.pendingDeletion) {
Is it also needed in a const member method?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26039
To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
