ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> componentchooserfilemanager.cpp:72
> bool first = true;
> - Q_FOREACH(const KService::Ptr& service, apps)
> + for (const KService::Ptr& service : apps)
> {
Opening curly brace should be on the same line than for
> componentchooserfilemanager.cpp:94
> QString storageId;
> - Q_FOREACH(QRadioButton* button, qFindChildren<QRadioButton*>(this)) {
> + for (QRadioButton* button : qAsConst(mDynamicRadioButtons)) {
> if (button->isChecked()) {
Space before * not after
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26179
To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
