crossi added a comment.
some nitpicks, otherwise looks good.
INLINE COMMENTS
> componentchooser.h:42
> virtual void defaults()=0;
> + virtual bool isDefaults() {
> + return false;
Can you make it const please.
> componentchooserbrowser.cpp:110
>
> - const auto &browsers =
> KServiceTypeTrader::self()->query(QStringLiteral("Application"),
> -
> QStringLiteral("'WebBrowser' in Categories"));
> + const auto contraints = QStringLiteral("'WebBrowser' in Categories and"
> + " ('x-scheme-handler/http' in
> ServiceTypes or 'x-scheme-handler/https' in ServiceTypes)");
Did you mean con**s**traints ?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26100
To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
