davidedmundson added a comment.

  That's quite a good idea.

INLINE COMMENTS

> sniproxy.cpp:154
>      //tell client we're embedding it
> -    xembed_message_send(wid, XEMBED_EMBEDDED_NOTIFY, m_containerWid, 0, 0);
> +    xembed_message_send(wid, XEMBED_EMBEDDED_NOTIFY, 0, m_containerWid, 
> XEMBED_VERSION);
>  

can you explain the swapping 0 and m_containerWid here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26079

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to