mvourlakos added a comment.
@trmdi this is a big change so it needs first to be approved theoretically
from main plasma devs
INLINE COMMENTS
> shellcorona.cpp:1046
>
> QRegion ShellCorona::availableScreenRegion(int id) const
> +if
> (!m_otherShellHelper->availableScreenRegion(static_cast<qint32>(id)).isNull())
> {
I think is missing a "{" here
> shellcorona.cpp:1047
> QRegion ShellCorona::availableScreenRegion(int id) const
> +if
> (!m_otherShellHelper->availableScreenRegion(static_cast<qint32>(id)).isNull())
> {
> + return
> m_otherShellHelper->availableScreenRegion(static_cast<quint32>(id));
indent issues for all function
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25807
To: trmdi, #plasma, mvourlakos, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart