davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> wiredconnectionwidget.cpp:79
> + m_widget->linkNegotiation->setCurrentIndex(LinkNegotiation::Manual);
> + }
>
can loadConfig can be called multiple times?
If so we need an explicit
else {
setCurrentIndex(LinkNegotiation::Ignore);
}
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
ethernet-changes
REVISION DETAIL
https://phabricator.kde.org/D24866
To: jgrulich, #plasma, #vdg, davidedmundson
Cc: davidedmundson, devurandom, ngraham, dvalter, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
ahiemstra, mart
