davidedmundson added inline comments.
INLINE COMMENTS
> historyimageitem.cpp:45
> if ( m_text.isNull() ) {
> - m_text = QStringLiteral( "%1x%2x%3 %4" )
> + m_text = QStringLiteral( "▨ %1x%2 %3bpp" )
> .arg( m_data.width() )
what's this square about?
Also if "bpp" is bits per pixel, we need to put it in i18n() for translation
> historymodel.h:70
> int m_maxSize;
> + bool m_displayImages;
> QMutex m_mutex;
It's best to initialise this.
I know setDisplayImages will always be called by the app, but it makes the
class more re-usable and robust.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22684
To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
