davidedmundson added inline comments.
INLINE COMMENTS
> kcm.cpp:198
> - // the keys sequence
> - if (!KGlobalAccel::promptStealShortcutSystemwide(this,
> conflicting, sequence)) {
> - return false;
This part appears to have gone?
> kscreensaversettings.cpp:46
> + m_lockAction->setText(i18n("Lock Session"));
> + KGlobalAccel::self()->setShortcut(m_lockAction, defaultShortcuts());
> +
given we have defined the defaults at a kconfigskeleton level should we just
call ->shortcut() here?
> kscreensaversettings.cpp:48
> +
> + addItem(new KPropertySkeletonItem(this, "shortcut",
> defaultShortcuts().first()), QStringLiteral("lockscreenShortcut"));
> +}
Could we handle the alternative shortcut by using a second property?
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D25212
To: ervin, #plasma, davidedmundson, bport, crossi, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
