alexde added inline comments.
INLINE COMMENTS
> acpi.c:129
> + } else if (state < 0) {
> + state = 0; /* prevent insane numbers with bad hardware */
> }
Are states > 100 or < 0 really well defined? Is it save to assume that a state
> 100 can be associated with 100?
> acpi.c:161
> + } else if (state < 0) {
> + state = 0; /* prevent insane numbers with bad hardware */
> + }
Are states > 100 or < 0 really well defined? Is it save to assume that a state
> 100 can be associated with 100 for example?
> nvidia.json:12
> "Description[nn]": "Statistikk til prosessorspesifikke GPU-ressursar
> for NVIDIA-kort",
> + "Description[pl]": "Statystyka dla zasobów GPU na proces dla kart
> Nvidii",
> "Description[pt]": "Estatísticas dos recursos do GPU por processo
> nas placas Nvidia",
This should maybe be a part of a separate patch as it seems unrelated.
REPOSITORY
R106 KSysguard
BRANCH
acpi-move-battery-to-sysfs
REVISION DETAIL
https://phabricator.kde.org/D25018
To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: alexde, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
