apol added inline comments.
INLINE COMMENTS
> globalaccel.cpp:50
> +
> +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString &storageId)
> +{
Why just return one if it can be a list?
> globalaccel.h:27
> +public:
> + static QKeySequence getMenuEntryShortcut(const QString &storageId);
> + static void changeMenuEntryShortcut(const QString &storageId, const
> QKeySequence &shortcut);
I'd call them `menuEntryShortcut` and `setMenuEntryShortcut`
REPOSITORY
R103 KMenu Editor
REVISION DETAIL
https://phabricator.kde.org/D25086
To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart