davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision.
REVISION SUMMARY There was a concious decision that when we add a new wallpaper we should append to the existing random order collection, rather than shuffle existing ones. The logic is fine but if we start with 0 wallpapers and then add 20 new ones we don't shuffle anything. This patch changes it so when a new batch of N wallpapers is added, those N are shuffled when appending to the existing sort order. BUG: 413463 FIXED-IN: 5.17.2 TEST PLAN qDebug + ran a few times REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24986 AFFECTED FILES wallpapers/image/slidefiltermodel.cpp To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
