jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> networkmodelitem.cpp:548
>
> + if (device && device->ipV4Config().isValid() && m_connectionState ==
> NetworkManager::ActiveConnection::Activated) {
> + if (!device->ipV4Config().gateway().isEmpty()) {
Because this if statement is the same as the one above and below, can you move
them together?
> networkmodelitem.cpp:575
> +
> + if (device && device->ipV6Config().isValid() && m_connectionState ==
> NetworkManager::ActiveConnection::Activated) {
> + if (!device->ipV6Config().nameservers().isEmpty()) {
Same for this one.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D24940
To: mibofra, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
