sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> davidre wrote in CMakeLists.txt:30
> I don't know but I just moved the find_package WindowSystem out of the if
> because now it would be needed unconditionally.
on osx the dialog is doing forceActiveWindow, not sure why only on osx though
> systeminformation.cpp:305
> + Q_UNREACHABLE();
> +}
You should probably just return QStringLiteral("Unknown") instead. The
unreachable is fairly dangerous here. If the enum gets extended but not
immediately updated in drkonqi this will lead to undefined behavior.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D24890
To: davidre, sitter
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, ahiemstra, mart
