davidedmundson added a comment.
Concept +1, I love layouts
INLINE COMMENTS
> configTimeZones.qml:32
> id: timeZonesPage
> - width: parent.width
> - height: parent.height
> + anchors.left: parent.left
> + anchors.right: parent.right
Do you need these?
Generally it's a sign of a problem or bad layering if the root item has anchors
in it.
> configTimeZones.qml:56
>
> + Rectangle {
> + id: messageWidget
If we're going to port stuff, we may as well port to:
https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1InlineMessage.html
the library version of this
> configTimeZones.qml:96
> + source: "dialog-warning"
> + opacity: messageWidget.opacity
> }
What's this for? Opacity should be inherited by children
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24853
To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
