broulik added inline comments.
INLINE COMMENTS
> main.cpp:141
> {
> - return
> KIconLoader::global()->theme()->querySizes(static_cast<KIconLoader::Group>(group));
> + KIconTheme theme(m_model->selectedTheme());
> + return theme.querySizes(static_cast<KIconLoader::Group>(group));
Does this `KIconTheme` instance need caching? I recall creating those parses a
tonne of files and directories and is quite slow
> IconSizePopup.qml:45
> - target: kcm
> - onIconSizesChanged: iconSizeSlider.updateSizes()
> }
Do you not need to leave this (or a similar) connect in place?
> IconSizePopup.qml:47-53
> + iconTypeList.currentCategory = [
> + "desktopSize",
> + "toolbarSize",
> + "mainToolbarSize",
> + "smallSize",
> + "panelSize",
> + "dialogSize"
I don't like this duplication, especially since sometimes you use
`currentIndex` and sometimes the `currentCategory`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D24846
To: bport, ervin, mart, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
