ngraham added inline comments.
INLINE COMMENTS
> DeviceListItem.qml:54
> + visible: portbox.count > 1
> + text: i18nd("kcm_pulseaudio", "Port")
> + }
While we're at it, let's also make this say "Port:"
> VolumeSlider.qml:44
> to: PulseAudio.MaximalVolume
> + stepSize: to / (PulseAudio.MaximalVolume / PulseAudio.NormalVolume *
> 100.0)
> visible: HasVolume
Hmm, I don't like how this makes tickmarks appear. If you need to round the
value, you can do that in `onMoved: { blabla; }`, or just round the value of
the label itself.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D24161
To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n,
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh,
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26,
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol,
mbohlender, mart
