mart added a comment.
overall to me looks a bit less balanced, but if VDG as a whole says it's ok, i'm fine with it. however there are some small things in the code to fix INLINE COMMENTS > davidedmundson wrote in introPage.qml:65 > Hardcoding sizes is generally frowned upon. > > Partly because things are user-configurable, partly because if every dev > hardcodes their own sizes we'll have an inconsistent mess everywhere. > > This patch has quite a few. Try and see what you can get rid of if it's a kirigami.heading, it should use the automatic sizes from there. All headings having the same size across everywhere is much more important than a perfect pixel alignment on a single place (which won't really work anyways, because we are dealing with fonts and pojn ts there) > davidedmundson wrote in introPage.qml:82 > See https://doc.qt.io/qt-5/qml-qtqml-qt.html#darker-method right, since you are using brightness only to have a darker color, you should use Qt.darker() REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender
