broulik added inline comments.
INLINE COMMENTS
> apol wrote in purposeplugin.cpp:127
> shouldn't this be a data: url or something like that? urls should only have
> urls
I was wondering the same but the email plugin does something very strange:
if (url.isLocalFile()) {
query.addQueryItem(QStringLiteral("attachment"), att.toString());
} else {
query.addQueryItem(QStringLiteral("body"), att.toString());
}
> apol wrote in purposeplugin.cpp:161
> Passing application/octet-stream should work, maybe it's a bug in Purpose.
I don't see any special-casing for default mimetype in Purpose.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D23151
To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
