fvogt added inline comments.
INLINE COMMENTS
> options.js:207
> +
> document.querySelectorAll("[data-requires-extension]").forEach((item) => {
> + let requiredExtension = item.dataset.requiresExtension;
> + let requiredMinimumVersion =
> Number(item.dataset.requiresExtensionVersionMinimum);
Consistency (and grammar): `let requiresExtension`
> options.js:215
> +
> + if (requiredMinimumVersion &&
> !isNaN(requiredMinimumVersion)) {
> + let runningVersion = status[requiredExtension].version;
Redundant
> settings.cpp:145
> + if (event == QLatin1String("getSubsystemStatus")) {
> + QJsonObject subsystemStatus;
> +
Move that a scope up as `QJsonObject ret` and you save two lines of code (and
more when more events get added)
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D21113
To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
