apol added a comment.
Is this only necessary for gtk2?
INLINE COMMENTS
> appearancegtk2.cpp:125
> +{
> + QRegularExpression regExp{propertyName + "=[^\n]*($|\n)"};
>
const?
> appearancegtk2.cpp:136
> + if (nonStringProperties.contains(propertyName)) {
> + newConfigString = QString{propertyName + "=" + newValue + "\n"};
> + } else {
This constructor isn't necessary.
> appearancegtk2.cpp:138
> + } else {
> + newConfigString = QString{propertyName + "=\"" + newValue + "\"\n"};
> + }
This constructor isn't necessary
> appearancegtk2.cpp:143
> + fileContents.replace(regExp, newConfigString);
> + } else {
> + fileContents = QString{newConfigString + "\n"} + fileContents;
This constructor isn't necessary.
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D21524
To: gikari, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
