-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1526/
-----------------------------------------------------------
(Updated 2009-10-19 21:10:07.356467)
Review request for Plasma, Aaron Seigo and Marco Martin.
Changes
-------
-Removed some more unused code
-cleaned up whitespace
-comments
screens are still not separately handled, but this is also not necessary since
a task cannot be on two screens at the same time (afaik).
So different grouping/sorting is only possible on different virtual desktops,
which makes sense to me.
Summary
-------
this fixes the manual sorting strategy, which is broken atm if the desktop is
changed.
Since the manual sorting strategy relies on AbstractGroupableItem pointer not
to change, we cannot remove it from the bookkeeping in case it returns (after a
desktop change for instance).
I don't know if this is acceptable because this results in the item never being
removed from the itemList until the groupmanager instance is deleted (lifetime
of the applet which created the instance).
Another option would be to identify tasks and groups by WId, which is a bit
more complicated, but if you think it would be better/cleaner, i could supply a
patch.
This addresses bug 200255.
https://bugs.kde.org/show_bug.cgi?id=200255
Diffs (updated)
-----
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h 1034424
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.cpp 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualsortingstrategy.h
1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualsortingstrategy.cpp
1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualgroupingstrategy.h
1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp
1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp
1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.h
1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.cpp
1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1034424
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h
1034424
Diff: http://reviewboard.kde.org/r/1526/diff
Testing
-------
Tried it, works.
Thanks,
Christian
_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel
