On Monday 22 September 2008 11:40:14 Ivan Čukić wrote: > > - amarok/src/context/plasma/animator.cpp:291 > > Division by 0 if frames < 3 > > issue1.diff attached
No-brainer. > > > - amarok/src/context/plasma/containment.cpp:991 > > Line 986 indicates that focusedApplet can be NULL. But focusedApplet is > > equal to applet. Therefore applet can be NULL here. > > This is in ContainmentPrivate::focusApplet (not line 986 anymore) > issue2.diff attached I don't see why the focusedApplet guard is needed in the first place, unless there's some possibility of getting a 0-pointer in the applets list. And there's plenty of other code that assumes it doesn't. So I think the guard should go. Alex -- Proud KDE hacker: http://www.kde.org Get KDE 4.1 - out now!
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
