----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/189/#review186 -----------------------------------------------------------
Ship it! seems sensible to me - Marco On 2008-09-11 07:49:26, Rafa? Mi?ecki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/189/ > ----------------------------------------------------------- > > (Updated 2008-09-11 07:49:26) > > > Review request for Plasma. > > > Summary > ------- > > This patch implements idea discussed on [EMAIL PROTECTED] This removes "Use > local time zone" check box and make clockDefaultsTo disabled by default. > clockDefaultsTo changes to enabled only if user selects something in > KTimeZoneWidget. This is going to make using UI quite intuitive. > > In code I used > if (d->ui.clockDefaultsTo->currentIndex() == 0) { > instead of just trusting that first position has "Local" string because this > string should be translated in future. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp > > /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/timezonesConfig.ui > > Diff: http://reviewboard.vidsolbach.de/r/189/diff > > > Testing > ------- > > > Thanks, > > Rafa? > > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
