On Saturday 30 August 2008, Aaron J. Seigo wrote: > On Friday 29 August 2008, Marco Martin wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.vidsolbach.de/r/166/ > > ----------------------------------------------------------- > > > > Review request for Plasma. > > > > > > Summary > > ------- > > > > this patch, really work in progress, adds a submenu in PanelController > > made with a Plasma::Dialog containing tha aligning options and the > > autohide/unerwindows options. done in a submenu because we were really at > > the limit for a 1024 (iirc hig says it still have to go well in 800x600?) > > yes, we're going to have to think about this. > > people also apparently hit the Remove button too easily and then just click > through the error message *sigh* it may be a candidate for moving somewhere > else as well ... /me sighs... whyohwhy? well it happens so must correct... those actions are added in a semi automatic way from a list of qactions... so should find a way to discriminate them to put some in a place and some other in another place, hmmm... > it's also a bit odd that the button is called Settings when the whole thing > is settings ... mm, yeah.. "other actions" booh :) > perhaps we could add Lock Widget in there as well, as it's probably not a > button people use Every Day. hmm, i tend to switch lokced/unlocked a lot don't know why and don't know if it could be significant also for others
Cheers, Marco Martin > > > otherwise i could put 3 autoexclusive buttons "Normal" "Auto hide" and > > "Panel under Windows" > > yes, i think that's the better idea. oki, will try. > > > Diffs > > ----- > > > > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h > > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp > > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h > > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp > > > > Diff: http://reviewboard.vidsolbach.de/r/166/diff > > diffs seem broken =/ oh, lol, got base path wrong again :P btw, main problem with this patch is that when i set the panel autohide on and update the strut the panel controller gets moved together the other windows :) otherwise kunda works Cheers, Marco Martin _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
